sriov-fec: add unit tests and switch to go client #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
klaskosk
force-pushed
the
sriov-fec-tests
branch
from
d51147d
to
478d83e
Compare
kononovn
reviewed
Nov 26, 2024
pkg/sriov-fec/nodeconfig_test.go
Outdated
| sriovfectypes.AddToScheme, | ||
| } | ||
|
|
||
| func TestNewNodeConfigBuilder(t *testing.T) { |
There was a problem hiding this comment.
Please add TestFec* prefix to all test functions
kononovn
requested changes
Nov 26, 2024
klaskosk
force-pushed
the
sriov-fec-tests
branch
from
478d83e
to
daf2dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.